Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change EnforceNetworkRulesForInternalStages ddl to parameter #3343

Conversation

yuukiyamanaka
Copy link
Contributor

@yuukiyamanaka yuukiyamanaka commented Jan 18, 2025

ENFORCE_NETWORK_RULES_FOR_INTERNAL_STAGES requires boolean parameter so I change the setting from ddl:keyword to ddl:parameter.

Test Plan

  • acceptance tests

References

#3344

@sfc-gh-jmichalak sfc-gh-jmichalak changed the title fix: change_enforce_network_policy_parameter_to_ddl_parameter fix: change EnforceNetworkRulesForInternalStages ddl to parameter Jan 20, 2025
Copy link
Collaborator

@sfc-gh-jmichalak sfc-gh-jmichalak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please set the target branch to dev we will update the contribution guide about this change.

Also, there is a missing entry about the fix from the migration guide, but we can add it on our side.

@sfc-gh-jmichalak sfc-gh-jmichalak changed the base branch from main to dev January 23, 2025 08:02
@sfc-gh-jmichalak
Copy link
Collaborator

/ok-to-test sha=9a61d4909a8438b77e036d83a6bf6d66c579924d

@sfc-gh-jmichalak
Copy link
Collaborator

/ok-to-test sha=9a61d4909a8438b77e036d83a6bf6d66c579924d

Copy link

Integration tests cancelled for 9a61d4909a8438b77e036d83a6bf6d66c579924d

Copy link

Integration tests failure for 9a61d4909a8438b77e036d83a6bf6d66c579924d

1 similar comment
Copy link

Integration tests failure for 9a61d4909a8438b77e036d83a6bf6d66c579924d

@sfc-gh-jmichalak sfc-gh-jmichalak merged commit beb01c7 into Snowflake-Labs:dev Jan 23, 2025
1 check passed
@yuukiyamanaka
Copy link
Contributor Author

Thank you!

sfc-gh-jmichalak added a commit that referenced this pull request Feb 4, 2025
<!-- Feel free to delete comments as you fill this in -->
- Add missing migration guide entry after #3343.
- Adjust a tag association example.
- Adjust and add missing notes about required warehouses.
- Fix a few typos.
- Remove @sfc-gh-fbudzynski from the list of protected users in sweepers
because he is not a contributor.
<!-- summary of changes -->

## Test Plan
<!-- detail ways in which this PR has been tested or needs to be tested
-->
* [ ] acceptance tests
<!-- add more below if you think they are relevant -->
* [ ] …

## References
<!-- issues documentation links, etc  -->
sfc-gh-jcieslak pushed a commit that referenced this pull request Feb 5, 2025
🤖 I have created a release *beep* *boop*
---


##
[1.0.3](v1.0.2...v1.0.3)
(2025-02-05)


### 🔧 **Misc**

* Add basic performance tests
([#3349](#3349))
([c57346b](c57346b))
* Add notes about managing grants on hybrid table
([#3368](#3368))
([e5e98bd](e5e98bd))
* Add preview and stable categories to resources and data sources in
docs
([#3370](#3370))
([b061434](b061434))
* Fix docs and update the protected users list
([#3365](#3365))
([f23e8cb](f23e8cb))
* Grant ownership common use cases
([#3356](#3356))
([97813b6](97813b6))
* Metric level fix with object renaming guide
([#3376](#3376))
([629ff92](629ff92))
* Move technical guides to the guide directory
([#3371](#3371))
([2b95809](2b95809))
* Prepare authentication methods guide
([#3364](#3364))
([c4a1c5f](c4a1c5f))
* Publish Performance tests summary
([#3359](#3359))
([d30d002](d30d002))
* Resolve issues and document account resource
([#3360](#3360))
([46b7a9d](46b7a9d))
* Upgrade tfplugindocs
([#3361](#3361))
([89f2b0a](89f2b0a))


### 🐛 **Bug fixes:**

* change EnforceNetworkRulesForInternalStages ddl to parameter
([#3343](#3343))
([beb01c7](beb01c7))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants